aMSN Forums
January 19, 2018, 08:28:32 pm *
Welcome, Guest. Please login or register.
Did you miss your activation email?

Login with username, password and session length
News: New forum for aMSN !!
 
   Home   Help Search Login Register  
Pages: [1]
  Print  
Author Topic: 2 Patches to fix broken rpm generation  (Read 4797 times)
gibus92
Newbie

Offline Offline

Posts: 10


View Profile
« on: August 31, 2012, 11:46:45 pm »

Hello,

I updated aMSN from subversion tree at revision r12413 and it appears that rpm package generation has been broken for a long time (and is still broken).
I am using  these 2 commands to build aMSN packages :

./configure --prefix=/usr --libdir=/usr/lib
make rpm

[...]

Check for unpackaged rpm: /usr/lib/rpm/check-files /usr/src/packages/BUILDROOT/amsn-0.99b-svn12412.x86_64
error: installed but unpackaged file(s):
   /usr/lib/amsn/utils/TkCximage/TkCximage.so
   /usr/lib/amsn/utils/TkCximage/pkgIndex.tcl
   /usr/lib/amsn/utils/asyncresolver/asyncresolver.tcl
   /usr/lib/amsn/utils/asyncresolver/libasyncresolver.so
   /usr/lib/amsn/utils/asyncresolver/pkgIndex.tcl
   /usr/lib/amsn/utils/farsight/pkgIndex.tcl
   /usr/lib/amsn/utils/farsight/tcl_farsight.so
   /usr/lib/amsn/utils/gupnp/gupnp.so
   /usr/lib/amsn/utils/gupnp/pkgIndex.tcl
   /usr/lib/amsn/utils/linux/capture/capture.so
   /usr/lib/amsn/utils/linux/capture/libng/libng.so
   /usr/lib/amsn/utils/linux/capture/libng/plugins/conv-mjpeg.so
   /usr/lib/amsn/utils/linux/capture/libng/plugins/drv0-v4l2.so
   /usr/lib/amsn/utils/linux/capture/libng/plugins/drv1-v4l.so
   /usr/lib/amsn/utils/linux/capture/libng/plugins/sn9c10x.so
   /usr/lib/amsn/utils/linux/capture/pkgIndex.tcl
   /usr/lib/amsn/utils/linux/linflash/flash.so
   /usr/lib/amsn/utils/linux/linflash/pkgIndex.tcl
   /usr/lib/amsn/utils/linux/traydock/libtray.so
   /usr/lib/amsn/utils/linux/traydock/pkgIndex.tcl
   /usr/lib/amsn/utils/tclISF/pkgIndex.tcl
   /usr/lib/amsn/utils/tclISF/tclISF.so
   /usr/lib/amsn/utils/tcl_siren/pkgIndex.tcl
   /usr/lib/amsn/utils/tcl_siren/tcl_siren.so
   /usr/lib/amsn/utils/webcamsn/pkgIndex.tcl
   /usr/lib/amsn/utils/webcamsn/webcamsn.so


rpm build error:
   installed but unpackaged file(s):
   /usr/lib/amsn/utils/TkCximage/TkCximage.so
   /usr/lib/amsn/utils/TkCximage/pkgIndex.tcl
   /usr/lib/amsn/utils/asyncresolver/asyncresolver.tcl
   /usr/lib/amsn/utils/asyncresolver/libasyncresolver.so
   /usr/lib/amsn/utils/asyncresolver/pkgIndex.tcl
   /usr/lib/amsn/utils/farsight/pkgIndex.tcl
   /usr/lib/amsn/utils/farsight/tcl_farsight.so
   /usr/lib/amsn/utils/gupnp/gupnp.so
   /usr/lib/amsn/utils/gupnp/pkgIndex.tcl
   /usr/lib/amsn/utils/linux/capture/capture.so
   /usr/lib/amsn/utils/linux/capture/libng/libng.so
   /usr/lib/amsn/utils/linux/capture/libng/plugins/conv-mjpeg.so
   /usr/lib/amsn/utils/linux/capture/libng/plugins/drv0-v4l2.so
   /usr/lib/amsn/utils/linux/capture/libng/plugins/drv1-v4l.so
   /usr/lib/amsn/utils/linux/capture/libng/plugins/sn9c10x.so
   /usr/lib/amsn/utils/linux/capture/pkgIndex.tcl
   /usr/lib/amsn/utils/linux/linflash/flash.so
   /usr/lib/amsn/utils/linux/linflash/pkgIndex.tcl
   /usr/lib/amsn/utils/linux/traydock/libtray.so
   /usr/lib/amsn/utils/linux/traydock/pkgIndex.tcl
   /usr/lib/amsn/utils/tclISF/pkgIndex.tcl
   /usr/lib/amsn/utils/tclISF/tclISF.so
   /usr/lib/amsn/utils/tcl_siren/pkgIndex.tcl
   /usr/lib/amsn/utils/tcl_siren/tcl_siren.so
   /usr/lib/amsn/utils/webcamsn/pkgIndex.tcl
   /usr/lib/amsn/utils/webcamsn/webcamsn.so
make: *** [rpm] Error 1

Older amsn packages used wrongly to install libraries in _datadir which is defined as /usr/share/amsn/<subdirs> but they should be installed in _libdir defined as /usr/lib/amsn/<subdirs>.
So, I added _libdir definition in Makefile.in and used it in file section of amsn.spec, and i got a new amsn package.

Here's come two patches. Please apply them in the subversion tree :

--- amsn/amsn.spec.old  2012-08-19 08:52:52.163567012 +0200                                                                                                                                                   
+++ amsn/amsn.spec      2012-08-20 18:15:19.624826085 +0200                                                                                                                                                   
@@ -102,6 +102,7 @@                                                                                                                                                                                           
 %{_bindir}                                                                                                                                                                                                   
 %{_desk_icons}/amsn.png                                                                                                                                                                                       
 %{_datadir}                                                                                                                                                                                                   
+%{_libdir}                                                                                                                                                                                                   
 %{_desk_applnk}/*.desktop                                                                                                                                                                                     
                                                                                                                                                                                                               
 %changelog
--- amsn/Makefile.in.old        2012-08-19 08:52:52.150564943 +0200
+++ amsn/Makefile.in    2012-08-20 18:15:55.795122962 +0200
@@ -299,6 +299,7 @@
        echo "%define _tmppath /tmp" >> THIS.AMSN.SPEC
        echo "%define _datadir $(dstdir)/$(PACKAGE)" >> THIS.AMSN.SPEC
        echo "%define _bindir $(slnkdir)" >> THIS.AMSN.SPEC
+       echo "%define _libdir $(libdir)/$(PACKAGE)" >> THIS.AMSN.SPEC
        echo "%define _doc_files $(doc_files)" >> THIS.AMSN.SPEC
        echo "%define _platform `uname -m`" >> THIS.AMSN.SPEC
        echo "%define _version $(BASEVERSION)" >> THIS.AMSN.SPEC
Logged
alexandernst
Developers
Super Power User
*
Offline Offline

Posts: 886



View Profile WWW
« Reply #1 on: September 01, 2012, 06:36:50 pm »

I just merged this! Thank you Wink
Logged
Pages: [1]
  Print  
 
Jump to:  

Powered by MySQL Powered by PHP Powered by SMF 1.1.11 | SMF © 2006-2009, Simple Machines LLC Valid XHTML 1.0! Valid CSS!