rpm package generation is broken

[gibus92]

Hello,

I updated aMSN from subversion tree today again and it appears that rpm package generation has been broken for a long time (and it is still).
I am using  these 2 commands to build aMSN packages :

./configure --prefix=/usr --libdir=/usr/lib
make rpm

[...]

Check for unpackaged rpm: /usr/lib/rpm/check-files /usr/src/packages/BUILDROOT/amsn-0.99b-svn12412.x86_64
error: installed but unpackaged file(s):
   /usr/lib/amsn/utils/TkCximage/TkCximage.so
   /usr/lib/amsn/utils/TkCximage/pkgIndex.tcl
   /usr/lib/amsn/utils/asyncresolver/asyncresolver.tcl
   /usr/lib/amsn/utils/asyncresolver/libasyncresolver.so
   /usr/lib/amsn/utils/asyncresolver/pkgIndex.tcl
   /usr/lib/amsn/utils/farsight/pkgIndex.tcl
   /usr/lib/amsn/utils/farsight/tcl_farsight.so
   /usr/lib/amsn/utils/gupnp/gupnp.so
   /usr/lib/amsn/utils/gupnp/pkgIndex.tcl
   /usr/lib/amsn/utils/linux/capture/capture.so
   /usr/lib/amsn/utils/linux/capture/libng/libng.so
   /usr/lib/amsn/utils/linux/capture/libng/plugins/conv-mjpeg.so
   /usr/lib/amsn/utils/linux/capture/libng/plugins/drv0-v4l2.so
   /usr/lib/amsn/utils/linux/capture/libng/plugins/drv1-v4l.so
   /usr/lib/amsn/utils/linux/capture/libng/plugins/sn9c10x.so
   /usr/lib/amsn/utils/linux/capture/pkgIndex.tcl
   /usr/lib/amsn/utils/linux/linflash/flash.so
   /usr/lib/amsn/utils/linux/linflash/pkgIndex.tcl
   /usr/lib/amsn/utils/linux/traydock/libtray.so
   /usr/lib/amsn/utils/linux/traydock/pkgIndex.tcl
   /usr/lib/amsn/utils/tclISF/pkgIndex.tcl
   /usr/lib/amsn/utils/tclISF/tclISF.so
   /usr/lib/amsn/utils/tcl_siren/pkgIndex.tcl
   /usr/lib/amsn/utils/tcl_siren/tcl_siren.so
   /usr/lib/amsn/utils/webcamsn/pkgIndex.tcl
   /usr/lib/amsn/utils/webcamsn/webcamsn.so


rpm build error:
   installed but unpackaged file(s):
   /usr/lib/amsn/utils/TkCximage/TkCximage.so
   /usr/lib/amsn/utils/TkCximage/pkgIndex.tcl
   /usr/lib/amsn/utils/asyncresolver/asyncresolver.tcl
   /usr/lib/amsn/utils/asyncresolver/libasyncresolver.so
   /usr/lib/amsn/utils/asyncresolver/pkgIndex.tcl
   /usr/lib/amsn/utils/farsight/pkgIndex.tcl
   /usr/lib/amsn/utils/farsight/tcl_farsight.so
   /usr/lib/amsn/utils/gupnp/gupnp.so
   /usr/lib/amsn/utils/gupnp/pkgIndex.tcl
   /usr/lib/amsn/utils/linux/capture/capture.so
   /usr/lib/amsn/utils/linux/capture/libng/libng.so
   /usr/lib/amsn/utils/linux/capture/libng/plugins/conv-mjpeg.so
   /usr/lib/amsn/utils/linux/capture/libng/plugins/drv0-v4l2.so
   /usr/lib/amsn/utils/linux/capture/libng/plugins/drv1-v4l.so
   /usr/lib/amsn/utils/linux/capture/libng/plugins/sn9c10x.so
   /usr/lib/amsn/utils/linux/capture/pkgIndex.tcl
   /usr/lib/amsn/utils/linux/linflash/flash.so
   /usr/lib/amsn/utils/linux/linflash/pkgIndex.tcl
   /usr/lib/amsn/utils/linux/traydock/libtray.so
   /usr/lib/amsn/utils/linux/traydock/pkgIndex.tcl
   /usr/lib/amsn/utils/tclISF/pkgIndex.tcl
   /usr/lib/amsn/utils/tclISF/tclISF.so
   /usr/lib/amsn/utils/tcl_siren/pkgIndex.tcl
   /usr/lib/amsn/utils/tcl_siren/tcl_siren.so
   /usr/lib/amsn/utils/webcamsn/pkgIndex.tcl
   /usr/lib/amsn/utils/webcamsn/webcamsn.so
make: *** [rpm] Erreur 1

Looks like new files have been compiled / added, and noone has updated the installer ...

[gibus92]

Older amsn packages used wrongly to install libraries in _datadir which is defined as /usr/share/amsn/<subdirs> but they should be installed in _libdir defined as /usr/lib/amsn/<subdirs>.
So, I added _libdir definition in Makefile.in and used it in file section of amsn.spec, and i got a new amsn package.

Here's come two patches. Please apply them in the subversion tree :

--- amsn.spec.old       2011-02-06 16:28:52.084346001 +0100
+++ amsn.spec   2012-08-20 10:34:57.640656235 +0200
@@ -102,6 +102,7 @@
 %{_bindir}
 %{_desk_icons}/amsn.png
 %{_datadir}
+%{_libdir}
 %{_desk_applnk}/*.desktop
 
 %changelog
--- Makefile.in.old     2012-08-20 10:40:27.816523338 +0200
+++ Makefile.in 2012-08-20 10:34:04.252268733 +0200
@@ -299,6 +299,7 @@
        echo "%define _tmppath /tmp" >> THIS.AMSN.SPEC
        echo "%define _datadir $(dstdir)/$(PACKAGE)" >> THIS.AMSN.SPEC
        echo "%define _bindir $(slnkdir)" >> THIS.AMSN.SPEC
+       echo "%define _libdir $(libdir)/$(PACKAGE)" >> THIS.AMSN.SPEC
        echo "%define _doc_files $(doc_files)" >> THIS.AMSN.SPEC
        echo "%define _platform `uname -m`" >> THIS.AMSN.SPEC
        echo "%define _version $(BASEVERSION)" >> THIS.AMSN.SPEC