GitHub Newbie

[Jonte]

Heya people.. I found your github and started submitting (i think?) a few things for the GTK frontend. I have a few questions now though Is there some plan of how things should be implemented, or can I choose this myself (to a certain degree)? I recently added the functionality to change nicknames in the GTK frontend, and I sort of chose my method of doing this myself, is that OK? What I'm looking for is, I guess, general rules for pushing code - until I learn the ropes

Also.. Who should I push the code to? Everyone or a specific person? (when clicking the pull request button).. And.. How do I know if/when my code is merged with the main code?

Thanks! Hope to be coding with you people in the future!

[kjir]

Hi,
the main repository is drf/amsn2 which is the one you have forked from. To request a pull, you go on your repository page and click on the button. We will then be notified of your request and we will review/merge the code. The best way to check if we merged your code would be to have the main repo set as a remote (you can do this with git remote add drf git://github.com/drf/amsn2.git) and keep it up to date (git fetch drf) and see the logs or use gitk (gitk --all will give you a nice overview of the current state). To merge with your current work, of course, the command is git merge drf/master.

As the other questions go, there are some guidelines (which I think you already read), but mostly it is up to you. The best thing would be that you join us on #amsn @ irc.freenode.net where we can discuss about these kind of things.

Thanks for your contribution!

[kakaroto]

cool, thanks for your contributions! I think requesting from everyone is a good thing so the first person with enough free time will merge your changes...
I suggest you read this : http://www.amsn-project.net/forums/viewtopic.php?t=5994
and for the general guidelines you were asking for, there are 3 emails to read.. the links to those emails are in the third post in the link above..
The other questions were well answered by kjir