[REV 10929] Received msg sound playing when message is sent

[Trappski]

Dunno if this is a general issue or just windows or if i just have managed to change some settings somewhere.

However, It's quite an annoyance that whenever i send a message the sound that usually just plays when i receive a message plays.
Haven't done anything special more than just updating to the latest rev.

[vivia]

Hi, can you find the exact SVN revision that caused this? Binary search between the current one and one that was known to work correctly. Thanx

[Trappski]

Sure. I'll take a look to see if i can find where it first occurs.

[Trappski]

It's the changes in chatwindow.tcl that causes this...
Revision where that file was updated is 10910. No changes have been made to that file after that.

Using a chatwindow.tcl prior to that does not cause this problem.
The cause is the removal of:

Code:

if { [::MSN::usersInChat $chatid] == $chatid } {
set usr_name $chatid
}

Wich if I'm not totally mistaken screws up this test?

Code:

if { $new_window == 1 || [::config::getKey sound_on_first_message 0] == 0 } {
#If no focus, and it's a message event, do something to the window
if { (([::config::getKey soundactive] == "1" && $usr_name != [::config::getKey login]) || \
 [string first ${win_name} [focus]] != 0) && ($msg != "" || [::config::getKey sound_on_first_message 0] == 1)} {
play_sound type.wav
}

      }

[vivia]

Right. Can you update svn and retry please?

[Trappski]

Right. Can you update svn and retry please?

Works!

[vivia]

Great! Thanks for finding it out!

[Trappski]

Great! Thanks for finding it out!

Happy to help in any way i can