[Solved] Notify: no alert if contact nickname begins by dash

[nico@nc]

Hi,

I noticed another problem with the notify plugin: if there is a space followed by a dash (-) in the name of the contact logging in/out, the notification window does not appear.

[21:15:28] executing notify-send exec notify-send --urgency=normal --expire-time=3000 --icon= --category=im.received {aMSN :} {- name vient de se connecter}
[21:15:28] Error lauching notify-send : Unknown option - name vient de se connecter

It seems that the contact name dash is considered as an option dash by notify-send. This should probably be solved by putting the message between quotation marks (for instance notify-send --option=value --option2=value2 "message" instead of notify-send --option=value --option2=value2 message).

[kakaroto]

nico, I don't think a quote would help.. you can try yourself if you want.. there's already a quote, otherwise it would say 'invalid number of arguments"... The solution is as simple as :
instead of :

Code:

notify-send --urgency=normal --expire-time=3000 --icon= --category=im.received "aMSN :" "- name vient de se connecter"

Code:

notify-send --urgency=normal --expire-time=3000 --icon= --category=im.received -- "aMSN :" "- name vient de se connecter"

[nico@nc]

Great! Thanks again for your help, kakaroto!  

Here is what I changed in the plugin file (from the 2008-05-10 version):

• Replace line 102:
  Code:
  proc exec_notify { txt {email ""} {urgency "normal"} {expire -1} {category "im.received"} {hint ""} } {
  
  by
  Code:
  proc exec_notify { txt {email ""} {urgency "normal"} {expire -1} {category "im.received"} {dashhack ""} {hint ""} } {]
  
  
• Replace line 223:
  Code:
         set cmd [concat [list "exec" $notify $urgency $expire $icon $category "$title" "$txt"  ]]      
  
  by
  Code:
         set cmd [concat [list "exec" $notify $urgency $expire $icon $category $dashhack "$title" "$txt"  ]]      
  
  
• Add after line 119 (set expire...):
  Code:
  set hack "--"

This could probably be done in a much more clean way, but it works like this.

Here is the modified file: http://dl.free.fr/lFzcxraxC.

[Yoda-BZH]

Hmmm

Why not just doing

Code:

           set cmd [concat [list "exec" $notify $urgency $expire $icon $category "--" "$title" "$txt"  ]]      

Dashhack should always by "--", so why using a new parametre ?

[kakaroto]

hehe, yeah, I agree with Yoda, the "--" should always be there, and it's not a "hack", it's a valid option that simply says "no more options, treat everything after this argument as being part of the text, even if it starts with a dash"... no need to read the notify-send man page, it's a standard option in many programs, so no need for a hack, just simply do it like Yoda-BZH said.
btw, Yoda, would you mind updating your plugin with plugininfo.xml version and the autoupdate info ? thx

[Yoda-BZH]

http://blog.yoda-bzh.net/index.php?post/2008/10/19/Notify-plugin-for-aMSN-updated-13