Hi Zaskar, thank you for your work again, you seem to have so little time but still dedicate it to this plugin which is a great addition to amsn. During the week end, if you think you should rest instead, feel free to rest instead of working on this plugin!
I didn't test the changes and I won't do it right now, probably tomorrow I'll test and commit to svn the new version, I'll just answer briefly everything you said :
About the wink name when you add a new one, I can't change it without testing, its a big change, but I can tell that if you left the name empty it will look for a name inside the wink (the one in the content.xml, or the animation filename if there's no name in content.xml). The trouble is that to see the wink name, I need to extract both files from the mco, and extract the cab file to, so I need to install the wink!. What I can do is to install it in tmp, and then, move it to winks. I'll work on it later.
maybe do it like msn, when you add a wink, you expect the xml to contain the name of the wink, so don't ask the user, simply add the wink and that's it.. if you can't find the wink's name, then put the filename, like you do now, and maybe ask the user... I understand you need to extract, and I don't know the code yet, so.. is it such a problem to extract, get the wink's name then add it to the index ?
about the version format, I understand you
I feel the exact same thing... I usually just increment gradually, I use 0.1 when I just started, or use 0.9 when it's almost done (like winks) then increment a little everytime.. I could get to 1.0, or 1.1, or whatever, I don't really care, as long as I can know that 0.9 is older than 1.0... also, I think 2.0 is used when you do a total rewrite... that's how I do it, but everyone does it his way, there's no real 'law' about it, and I always feel the same as you
Finally, about the xml functions, I understand and I agree, if it works, don't change it, I just think it would be better to use a common API... BUT I fully agree with you that this should be the lowest priority.. do it once the plugin is stable, has all the features, etc...
Now here's the todo list of what I wrote to you last time.. I'm just requoting it so it stays on top and doesn't get forgotten... I removed the entries you said were fixed :
3 - When we add a new wink, it asks us for the name THEN it extracts the wink.. maybe it should extract the wink THEN ask us for the name, this way, wrong mco files will directly show an error without having to enter a name THEN realize we chose the wrong file.. also, it will allow the plugin to go get the wink's name from the content.xml, because I just downloaded hundreds of winks, and all the filenames are weird, so I have to go manually extract the mco, then the .cab, then read the content.xml, then get the wink's name, then add the wink into amsn and put the right name in it. if the plugin could automatically fetch the wink's name, that would be cool!
6 - I looked at the code, you're still not using the xml2list API ?
which means you're almost done
tomorrow, I'll commit your new version and put the plugin in the main site (I just realized it's not there yet!) so more people can test it and hopefully report no bugs
thanks
keep it up!
[EDIT] ps: WOW, 255 posts in this thread, and it's not even a sticky thread, you beat the chameleon thread which was the longest with 244 replies... congrats on the best plugin so far
