aMSN Forums
October 25, 2014, 03:31:58 pm *
Welcome, Guest. Please login or register.
Did you miss your activation email?

Login with username, password and session length
News: New forum for aMSN !!
 
   Home   Help Search Login Register  
Pages: 1 ... 16 17 [18] 19 20 21
  Print  
Author Topic: Winks pluggin, a little work  (Read 211655 times)
kakaroto
Administrator
Super Power User
*****
Offline Offline

Posts: 9428


View Profile WWW
« Reply #255 on: March 20, 2007, 05:37:29 am »

Hi Zaskar, thank you for your work again, you seem to have so little time but still dedicate it to this plugin which is a great addition to amsn. During the week end, if you think you should rest instead, feel free to rest instead of working on this plugin!
I didn't test the changes and I won't do it right now, probably tomorrow I'll test and commit to svn the new version, I'll just answer briefly everything you said :
Quote
About the wink name when you add a new one, I can't change it without testing, its a big change, but I can tell that if you left the name empty it will look for a name inside the wink (the one in the content.xml, or the animation filename if there's no name in content.xml). The trouble is that to see the wink name, I need to extract both files from the mco, and extract the cab file to, so I need to install the wink!. What I can do is to install it in tmp, and then, move it to winks. I'll work on it later.

maybe do it like msn, when you add a wink, you expect the xml to contain the name of the wink, so don't ask the user, simply add the wink and that's it.. if you can't find the wink's name, then put the filename, like you do now, and maybe ask the user... I understand you need to extract, and I don't know the code yet, so.. is it such a problem to extract, get the wink's name then add it to the index ?

about the version format, I understand you Cheesy I feel the exact same thing... I usually just increment gradually, I use 0.1 when I just started, or use 0.9 when it's almost done (like winks) then increment a little everytime.. I could get to 1.0, or 1.1, or whatever, I don't really care, as long as I can know that 0.9 is older than 1.0... also, I think 2.0 is used when you do a total rewrite... that's how I do it, but everyone does it his way, there's no real 'law' about it, and I always feel the same as you Smiley

Finally, about the xml functions, I understand and I agree, if it works, don't change it, I just think it would be better to use a common API... BUT I fully agree with you that this should be the lowest priority.. do it once the plugin is stable, has all the features, etc...

Now here's the todo list of what I wrote to you last time.. I'm just requoting it so it stays on top and doesn't get forgotten... I removed the entries you said were fixed :
Quote

3 - When we add a new wink, it asks us for the name THEN it extracts the wink.. maybe it should extract the wink THEN ask us for the name, this way, wrong mco files will directly show an error without having to enter a name THEN realize we chose the wrong file.. also, it will allow the plugin to go get the wink's name from the content.xml, because I just downloaded hundreds of winks, and all the filenames are weird, so I have to go manually extract the mco, then the .cab, then read the content.xml, then get the wink's name, then add the wink into amsn and put the right name in it. if the plugin could automatically fetch the wink's name, that would be cool!
6 - I looked at the code, you're still not using the xml2list API ?

which means you're almost done Smiley
tomorrow, I'll commit your new version and put the plugin in the main site (I just realized it's not there yet!) so more people can test it and hopefully report no bugs Smiley

thanks
keep it up!


[EDIT] ps: WOW, 255 posts in this thread, and it's not even a sticky thread, you beat the chameleon thread which was the longest with 244 replies... congrats on the best plugin so far Smiley
Logged

KaKaRoTo
[S]haDoW
Newbie

Offline Offline

Posts: 24


View Profile
« Reply #256 on: March 21, 2007, 10:33:22 am »

At last SVN version:
Code:

Revisione corrente: 8265
U    amsn/plugins/winks/lang/langit
U    amsn/plugins/winks/plugininfo.xml
U    amsn/plugins/winks/winks.tcl
Aggiornato alla revisione 8266.
------------------------------------------------------------------------
r8266 | kakaroto | 2007-03-21 04:48:30 +0100 (mer, 21 mar 2007) | 6 lines


when i try to load winks plugin:

Code:
Winks: Failed to load source with result:
missing close-brace
Logged
xoan
Power user
*
Offline Offline

Posts: 99



View Profile WWW
« Reply #257 on: March 21, 2007, 11:07:50 am »

Close-brace is (I think):

Code:
Index: winks.tcl
===================================================================
--- winks.tcl   (revisión: 8266)
+++ winks.tcl   (copia de trabajo)
@@ -115,6 +115,7 @@
                                        if {[file exists [file join $dir "cabextract"]} {
                                                set ::config(cabextractor) [file join $dir "cabextract"]
                                                CheckCabextractVersion
+                                       }
                                }
                        }
                }


But with this patch, winks.tcl crashes with this error: "Plugins System: Can't initialize plugin:init procedure caused an internal error":

Code:
[11:02:28] core: Getting Winks and author
[11:02:28] core: Winks_author
[11:02:28] core: Getting Winks and plugin_version
[11:02:28] core: Winks_plugin_version
[11:02:28] core: Getting Winks and description
[11:02:28] core: Winks_description
[11:02:31] core: Getting Winks and amsn_version
[11:02:31] core: Winks_amsn_version
[11:02:31] core: Getting Winks and plugin_file
[11:02:31] core: Winks_plugin_file
[11:02:31] core: Getting Winks and plugin_namespace
[11:02:31] core: Winks_plugin_namespace
[11:02:31] core: Getting Winks and init_proc
[11:02:31] core: Winks_init_proc
[11:02:31] core: Plugin needs 0.97
[11:02:31] core: appending to loadedplugins
[11:02:31] core: Initializing plugin Winks with winks::Init
[11:02:32] core: Plugin Systems: RegisterEvent called with Winks WinkReceived ReceivedWink
[11:02:32] core: Getting Winks and plugin_namespace
[11:02:32] core: Winks_plugin_namespace
[11:02:32] core: Binding WinkReceived to ReceivedWink
[11:02:32] core: Plugin Systems: RegisterEvent called with Winks chatwindowbutton AddWinksButton
[11:02:32] core: Getting Winks and plugin_namespace
[11:02:32] core: Winks_plugin_namespace
[11:02:32] core: Binding chatwindowbutton to AddWinksButton
[11:02:32] core: Plugin Systems: RegisterEvent called with Winks DataCastPacketReceived ReceiveSomething
[11:02:32] core: Getting Winks and plugin_namespace
[11:02:32] core: Winks_plugin_namespace
[11:02:32] core: Binding DataCastPacketReceived to ReceiveSomething
[11:02:32] core: Plugin Systems: RegisterEvent called with Winks PacketReceived ReceiveSomething
[11:02:32] core: Getting Winks and plugin_namespace
[11:02:32] core: Winks_plugin_namespace
[11:02:32] core: Binding PacketReceived to ReceiveSomething
[11:02:32] core: Initialization of plugin Winks with winks::Init failed
invalid bareword "CheckCabextractVersion"
in expression " ! CheckCabextractVersion ";
should be "$CheckCabextractVersion" or "{CheckCabextractVersion}" or "CheckCabextractVersion(...)" or ...
invalid bareword "CheckCabextractVersion"
in expression " ! CheckCabextractVersion ";
should be "$CheckCabextractVersion" or "{CheckCabextractVersion}" or "CheckCabextractVersion(...)" or ...
    (parsing expression " ! CheckCabextractVers...")
    invoked from within
"if { ! CheckCabextractVersion } {
if {[file exists [file join $dir "cabextract"]} {
set ::config(cabextractor) [file join $dir "cabextract"]
..."
    (procedure "::winks::Init" line 63)
    invoked from within
"::${namespace}::${init_proc} [file dirname $file]"
[11:02:32] Desktop Integration: aMSN called messageBox {type='ok', icon='info'}
[11:02:32] Desktop Integration: Calling 'zenity --info'
[11:02:32] core: Unloading plugin Winks
[11:02:32] core: Getting Winks and plugin_namespace
[11:02:32] core: Winks_plugin_namespace
[11:02:32] core: UnRegistering command 0 from ::winks::ReceivedWink...
[11:02:32] core: UnRegistering command 2 from ::Nudge::received ::Games::PacketReceived ::winks::ReceiveSomething...
[11:02:32] core: UnRegistering command 1 from ::Nudge::received ::winks::ReceiveSomething...
[11:02:32] core: UnRegistering command 4 from ::Nudge::sendbutton ::Nudge::blockbutton ::draw::AddInkSwitchButton ::SpellCheck::checkspellbutton ::winks::AddWinksButton...
[11:02:32] core: Getting Winks and plugin_namespace
[11:02:32] core: Winks_plugin_namespace
[11:02:32] core: Getting Winks and deinit_proc
[11:02:32] core: Winks_deinit_proc
[11:02:32] core: Error in deinit proc : wrong # args: should be "::winks::DeInit dir"
[11:02:32] core: save_config: saving plugin config for user xoanXXXX@XXXX.com in /home/xoan/.amsn/xoanXXXX_XXXX_com]
[11:02:32] core: save_config: saving plugin config_file. Opening of file returned : file10
[11:02:32] core: Getting Nudge and plugin_namespace
[11:02:32] core: Nudge_plugin_namespace
[11:02:32] core: save_config: Saving from Nudge's namespace: Nudge
[11:02:32] core: Getting Cam Shooter and plugin_namespace
[11:02:32] core: {Cam Shooter_plugin_namespace}
[11:02:32] core: Getting Organize Received Files and plugin_namespace
[11:02:32] core: {Organize Received Files_plugin_namespace}
[11:02:32] core: save_config: Saving from Organize Received Files's namespace: organize_received
[11:02:32] core: Getting Fortune and plugin_namespace
[11:02:32] core: Fortune_plugin_namespace
[11:02:32] core: Getting emotes and plugin_namespace
[11:02:32] core: emotes_plugin_namespace
[11:02:32] core: Getting Music and plugin_namespace
[11:02:32] core: Music_plugin_namespace
[11:02:32] core: save_config: Saving from Music's namespace: music
[11:02:32] core: Getting Inkdraw and plugin_namespace
[11:02:32] core: Inkdraw_plugin_namespace
[11:02:32] core: Getting Desktop Integration and plugin_namespace
[11:02:32] core: {Desktop Integration_plugin_namespace}
[11:02:32] core: save_config: Saving from Desktop Integration's namespace: desktop_integration
[11:02:32] core: Getting Games and plugin_namespace
[11:02:32] core: Games_plugin_namespace
[11:02:32] core: save_config: Saving from Games's namespace: Games
[11:02:32] core: Getting SpellCheck and plugin_namespace
[11:02:32] core: SpellCheck_plugin_namespace
[11:02:32] core: save_config: Saving from SpellCheck's namespace: SpellCheck
[11:02:32] core: Getting WebSearch and plugin_namespace
[11:02:32] core: WebSearch_plugin_namespace
[11:02:32] core: save_config: Saving from WebSearch's namespace: searchplugin
[11:02:32] core: Getting DualDisplayPicture and plugin_namespace
[11:02:32] core: DualDisplayPicture_plugin_namespace
[11:02:32] core: Getting UserStatus and plugin_namespace
[11:02:32] core: UserStatus_plugin_namespace
[11:02:32] core: Getting gnotify and plugin_namespace
[11:02:32] core: gnotify_plugin_namespace
[11:02:32] core: save_config: Saving from gnotify's namespace: gnotify
[11:02:32] core: Getting remind and plugin_namespace
[11:02:32] core: remind_plugin_namespace
[11:02:32] core: save_config: Saving from remind's namespace: remind
[11:02:32] core: save_config: Plugins config saved


I don't know if one ore more of others plugins are in conflict with Winks Plugin (or viceversa); or if a CheckCabextractVersion called isn't correct.
Logged
Bloodsucker
Power user
*
Offline Offline

Posts: 101


View Profile
« Reply #258 on: March 23, 2007, 11:01:15 am »

i have the same error when i try to enable

Winks: Failed to load source with result:
missing close-brace
Logged
kakaroto
Administrator
Super Power User
*****
Offline Offline

Posts: 9428


View Profile WWW
« Reply #259 on: March 23, 2007, 03:04:23 pm »

yes, we know, Zaskar said he couldn't test the changes he made because he doesn't have an internet connection... I have no time to take care of that for him, so when he'll be back, he'll fix the bugs and send a new workable version, in the meantime, use the previous version!
Logged

KaKaRoTo
Bloodsucker
Power user
*
Offline Offline

Posts: 101


View Profile
« Reply #260 on: March 24, 2007, 12:43:52 am »

i'm very impacient! Cheesy
Logged
Zaskar
Super Power User
**
Offline Offline

Posts: 159


View Profile
« Reply #261 on: March 24, 2007, 05:15:51 pm »

Here's the fixed one:

http://in.solit.us/archives/download/16261

It will try to find out the cabextract and the flashplayer configurations:
For cabextract:It first checks for extract32 (for windows version), then checks for cabextract (to see if there's one already installed), then looks for one inside the plugin directory.
For flashplayer: if will try first with gnash to see if there's one in the system, then it will look for a gnash in the plugin directory, and then it will look for another there that should be named flashplayer. If we are on windows, it will add .exe at the end of the command (it means that it looks for gnash.exe or flashplayer.exe). For gnash, it also finds out its version and sets/unsets playing inside chat window option.
Both thing are made to be checked only on the first time you load the plugin and to be remembered. The real condition for the guessing is that cabextrator or flashplayer fields in the plugin configuration dialog should be empty.

Edited: I've changed the link because the "play inside chat window" when it guesses the flash player was inverted.
Logged
kakaroto
Administrator
Super Power User
*****
Offline Offline

Posts: 9428


View Profile WWW
« Reply #262 on: March 24, 2007, 09:03:25 pm »

Hi Zaskar,
I didn't test the plugin yet, but I saw in the diff when I was commiting that you use : [file join $dir gnash] etc.. in the CheckFlashPlayer and CheckCabExtractor, but $dir is not defined.. you don't pass $dir as argument for those two functions.. I think that will cause a bug for sure!


EDIT:
ok, I just tested.. when we clear the cab/flash entries, and we load, we get this :
Quote

[16:08:59] core: Initialization of plugin Winks with winks::Init failed
can't read "dir": no such variable
can't read "dir": no such variable
    while executing
"file join $dir "gnash.exe""
    (procedure "GuessFlashplayer" line 19)
    invoked from within
"GuessFlashplayer"
    (procedure "::winks::Init" line 78)
    invoked from within
"::${namespace}::${init_proc} [file dirname $file]"

I also see this in the plugin's log :
Quote

[16:08:39] core: Error in deinit proc : wrong # args: should be "::winks::DeInit dir"



EDIT 2 : Ok, I fixed it in revision 8287 as well as fixing a way of using catch statements... please make sure to get my modifications before you continue working on the plugin... thanks!
Logged

KaKaRoTo
Zaskar
Super Power User
**
Offline Offline

Posts: 159


View Profile
« Reply #263 on: March 25, 2007, 01:26:36 am »

Here's the new one ( this one works;) ):

http://in.solit.us/archives/download/16486

If fixes what kakaroto said in last post, and changes the way it adds a new wink (now it checks if its a wink, and it let you see the name, animation and thumbnail before adding it).
Logged
kakaroto
Administrator
Super Power User
*****
Offline Offline

Posts: 9428


View Profile WWW
« Reply #264 on: March 25, 2007, 07:10:23 am »

Hi Zaskar, thanks for the new version, and btw, glad you have internet back!
I just committed your changes in r8292.. I only changed the version in the plugininfo.xml into 20070325 because the version should be used by the autoupdater and I'm not sure how it would handle a dash in it.
Logged

KaKaRoTo
[S]haDoW
Newbie

Offline Offline

Posts: 24


View Profile
« Reply #265 on: March 25, 2007, 10:40:47 am »

This one is ok Smiley
the missing key of italian translation :
Code:
winks_file_is_not_a_wink Il file non contiene animoticon.


Bye
Logged
Zaskar
Super Power User
**
Offline Offline

Posts: 159


View Profile
« Reply #266 on: March 25, 2007, 03:55:58 pm »

Kakaroto: About version number... I'll be out for a week again. Remember that if 0.97 release comes you can freely change plugin version to 1.0, I'll adapt to this numbering if you think it's the better way.
Logged
Fenix-TX
Super Power User
**
Offline Offline

Posts: 660


View Profile
« Reply #267 on: March 26, 2007, 10:39:51 am »

Hi Zaskar, there is a little typo in spanish translation, not important:

Quote
Notificar los guiños recibidos en una linea


should be:

Quote
Notificar los guiños recibidos en una línea
Logged
Trappski
Super Power User
**
Offline Offline

Posts: 200



View Profile
« Reply #268 on: March 26, 2007, 05:58:56 pm »

freshly translated keys for langsv:

Code:

winks_file_is_not_a_wink Filen innehåller ingen blinkning.
winks_use_queque_in Använd en uppspelnings-kö när blinkningar spelas i konversationsfönstret.
winks_use_queque_out Använd en uppspelnings-kö när blinkningar spelas utanför konversationsfönstret.


and this one should replace the old misspelled one:
Code:

winks_play_wink_immediatly_when_recived Spela blinkning direkt efter nedladdning.

original spelling for key was:
winks_play_wink_inmediatly_when_recived
Logged

gbowden
Guest
« Reply #269 on: April 12, 2007, 10:51:34 pm »

I've created .mco files from the Microsoft wink files provided with MSN Live, you can download them below:

http://hyperupload.com/download/02bd1b9310/mco.zip.html

Regards,

Greg
Logged
Pages: 1 ... 16 17 [18] 19 20 21
  Print  
 
Jump to:  

Powered by MySQL Powered by PHP Powered by SMF 1.1.11 | SMF © 2006-2009, Simple Machines LLC Valid XHTML 1.0! Valid CSS!