Winks pluggin, a little work

[kakaroto]

Hi,
Thx NWM for the explanation, you're totally right in everything you said about upvar. I'd only like to add that we do this so that, in your proc, if you do a :
set mylocalvar 10
then even in that function which is outside of your proc's scope, the value of 'mylocalvar' is getting changed. As you said, emulating the pass by reference behavior.

About winks, are you sure ? I would doubt something like that!!! because first, they didn't do it for DPs or custom smileys, so why do it for winks, secondly because people will BUY winks, and because of that, you can't just pay 5 or 10$ for a wink and everyone you send it to is going to have it for free... it's the P2P, napster/kazaa/bittorrent ideal, but it's way too far from being Micro$oft's  ideal... so I'm pretty sure you can't reuse a wink you received, only the default ones.
(note that M$ went all the way to the trouble of signing each wink with a certificate and will only accept and play correctly signed winks by microsoft, just to make sure you can't "create your own winks" without paying them, so the 'steal wink' feature is sure not going to be part of their specs...
I do think the cache/ dir should contian other users' winks and not your own and you should not play those unless you browse to add a wink and choose one from there.

[Zaskar]

Ok, but the fact is that in this version of the plugin, every wink that the other clients sends you also became your wink. (I've did it in that way because it was the easy for me and for testing, it's not the best, but I'll improve the interface later, first I want to fix and clean...). That's why I copy the file out of cache. About MCO, maybe there's a little confusion.

The MCO is itself a cab, but it has inside another cab (with cab extension) and a content.xml (this one has the stamp). That cab is the one we send as an msnobj, no the mco, so we never keep the mco. That cab has inside the thumbnail, the animation, and another content.xml. In the wink folder I want to keep the cab in both forms: compressed and uncompress. The first one to send, the second to play and draw the menu. None of them is for me temporal.

There's one trouble about the transfer of the msn object. If don't delete the stamp field from the data berore doing the RequestMsnobjEx it doesn't work, but in that case if there's another amsn in the otherside, the msnobject that is asked for is not the same that it registered, so it's not sent. Now I register both object versions for testing, but I'll see how to fix soon.

Anyway, here's the new code. I don't force the file name, I don't modify/move it.  Again, it's cleaner than the last one, but not even near finished. There's still LOT of work to do, but its an advance.

http://in.solit.us/archives/show/7626

[NoWhereMan]

it's the P2P, napster/kazaa/bittorrent ideal, but it's way too far from being Micro$oft's  ideal... so I'm pretty sure you can't reuse a wink you received, only the default ones.

well this doesn't mean this plugin should behave in the same way  :twisted:   hmm, but it wouldn't be something ...ahem... good :/

[Fenix-TX]

With the plugin, i have this problem:

Hi! Today i've download the new SVN and now, the number of contacts on a group, when i connect is 0 in all groups, but there are contacts.

See the screenshot:

[kakaroto]

@Fenix,
are you using the latest SVN version? and are you 100% sure it comes from this plugin ?
btw, nice skin, which one is it ?

@NWM
yes, of course we should *allow* someone to 'steal' a wink, but not do it without asking, + you said "in the official client" :p

@Zaskar
ok, I understand you a bit better now, but now I have other questions :
1 - why an .mco ? if we send the cab inside the mco then it means the cab is the wink, so where does the mco come from ? we send a cab file that's it and that's what we receive, so why mco containing another cab ?? you also said that we never keep the mco, so where is it coming from ? is it the file format you receive from microsoft when you buy a wink ?
2 - you should definitely, at 100% not automatically add a received wink, you should allow the users to right click and add it automatically, but that's it, imagine someone sends you 100 winks on purpose, then you'll have so many that you won't be able to see your own winks anymore, this is wrong, a software should never take decisions on its own, so the plugin should never automatically add received winks on purpose (unless there's an option for it in the configuration of the plugin, in which case that option should be disabled by default)
3 - I understood this stamp/msnobj problem and you're right, you should create 2 msnobjs one with and one without the stamp, that's perfect, about how to remove the stamp to send the invite, I would suggest you use the [xml2list] and [list2xml] calls to do this cleanly

Keep up the good work! I can't wait to see this in the final stage!

[Zaskar]

1) When you search for a wink (for example in google), you find that you download an mco and some tool to install it. The file we send is a cab, but the mco also contains an context.xml with some extra information. (The information I use is for example the stamp, it's in the mco but not in the cab). I thinks that it is the file you get when you buy/download a wink.
2) Of course, that was never the final idea, there will be some option like in custom smileys, just give me some time, that was easy to start testing. I'll rewrite the interface (maybe the menu behavior and the message you see when sending or receiving one).
3) But one of those objects is never requested. It stays some where like a memory leak? I don't know if that's good. I'll try to find out why amsn doesn't send the invite if I include the stamp (may be the fact that in that case the invite should be divided in three packets has something to do).

I've uploaded today a new version. It fixes some minor bugs (like the wink name encoding for the friendly field, add a catch to avoid errors if the thumbnail cant be loaded, avoid the need of the & in the flash player arguments, etc) and the readme fixed (I don't know what happened with the first one). It's in:

http://in.solit.us/archives/show/7647

[kakaroto]

Hi,
1) ok, good. This means finding the stamp field will be difficult, we need to save those stamps at all costs, without the proper stamp, we can't send the wink. The stamp is actually a base64 encoded M$ certificate for authorizing the use of that wink, if it's wrong, then the user won't see the wink.
3) no, don't worry, it's not a memory leak, it's memory being used, that's all. a memory leak is when memory is always being created without being deleted, in this case, if you send the wink twice, the memory won't go up, + it's so small,y ou don't need to worry about it. so yes, you should absolutely create two msnobj. the reason why the file doesn't get sent if the stamp is not included for amsn is because the msnobj is different so amsn doesn't recognize it, that's all.

[Fenix-TX]

@Fenix,
are you using the latest SVN version? and are you 100% sure it comes from this plugin ?
btw, nice skin, which one is it ?

Yes, i've the latest svn, if i use amsn with wink plugin i have that problem, but if i disable the plugin, and open amsn again, i don't have that problem.

That's skin it's emerald 2.0 but i made some changes (i hope that Gus doesn't have any objection for that, and it's only on my computer)

EDIT
Well, with latest winks is working fine now.  I don't have that problem with groups on my contact list.

EDIT2
I want to say that i'm using klash to reproduce winks. Klash is the standalone KDE-based player (gnash).

[GuS-Arg]

That's skin it's emerald 2.0 but i made some changes (i hope that Gus doesn't have any objection for that, and it's only on my computer)

Indeed.. looks better... i was planing to use one bluish color as background image on the Groups names.

Thats nice Fenix

[NoWhereMan]

how's this plugin going?

[Fenix-TX]

That's skin it's emerald 2.0 but i made some changes (i hope that Gus doesn't have any objection for that, and it's only on my computer)

Indeed.. looks better... i was planing to use one bluish color as background image on the Groups names.

Thats nice Fenix

Thanks Gus! I'll wait to your version . I love you work it's very nice.

[square87]

I can send but I cannot see
then...
if I click on a wink with right click i get:

Code:

wrong # args: should be "::winks::PlayWink wfile wname"
    while executing
"::winks::PlayWink "/home/A/.amsn/MYMSN/winks/01effcdf56a3512ad7f9514c771c41b8/eyeball.swf" Occhio saltellante"
    (command bound to event)

if i do from Konsole
$gnash /home/A/.amsn/MYMSN/winks/01effcdf56a3512ad7f9514c771c41b8/eyeball.swf
it works!

[vivia]

the problem is with a whitespace on wname . Zaskar: how is development going?

[ekz]

I can send but I cannot see
then...
if I click on a wink with right click i get:

Code:

wrong # args: should be "::winks::PlayWink wfile wname"
    while executing
"::winks::PlayWink "/home/A/.amsn/MYMSN/winks/01effcdf56a3512ad7f9514c771c41b8/eyeball.swf" Occhio saltellante"
    (command bound to event)

if i do from Konsole
$gnash /home/A/.amsn/MYMSN/winks/01effcdf56a3512ad7f9514c771c41b8/eyeball.swf
it works!

I use "firefox" as swf player command (without arguments )

SAludos

[kakaroto]

"Occhio saltellante"  having a space is interpreted as 2 arguments because it's bound to an event... but still, I can't figure out how "Occhio saltellante" can be a "$wname"..