Mobile and Offline messenging, and Logs/history bugs

[sulfur]

I was noticing today that mobile messages don't go into the history/log files at all.  It struck me as rather odd, and I was wondering if there was some specific reason why this was the case, or if it was merely an oversight.

Edit:

Offline messages in MSN specifiy the time that they were sent.  The time in aMSN is when you read it.   Not the same.

Edit 2:

Since this is now a bug discussion rather than a suggestion, it might deserve to be moved into the development section, but I'll leave that up to an admin to decide.

[kakaroto]

Hi,
it is merely an oversight. In the same way that offline messages (available in the SVN version only) are not in the appearing in the log files.
Thank you for noticing and reporting. We'll try to fix it soon.

[sulfur]

beaut.  thanks for the quick response.

i noticed when one of my friends mobile'd me in response to a msg to her (same way), and i went to look in the log and couldn't find it to figure out what the "yes" response was for!  

so, since it's being investigated now, would the last few lines be put into the message box, as they are for regular msgs (assuming that option is tagged... of course)?

[sulfur]

further followup, i noticed that there are no time tags on the received mobile msgs (not sure if there are on offline ones, i've not seen one in quite some time).  does a time tag not come along with the msg?  i know that mobile->mobile ones carry the message sent timestamp.

and last followup (i think).  to go with the no time tags, there's no "last message received at" time tagged on those mobile msgs.  there is on the "real" msn, i checked that this evening to be certain.

also, not sure if the subject of this discussion can be fixed to be "logs" rather than "lohs", but it should.

[kakaroto]

thx for the feedback again. I'll keep that in mind when I'll have some time to look into all of that.
In the meantime, I changed the subject of this thread, you could have done it by editing your first message of the thread.

[sulfur]

I changed the subject of this thread, you could have done it by editing your first message of the thread.

ah, i tried that and it didn't seem to work.  must've hit the wrong button somewhere.  whoops.

[kakaroto]

As far as I know, this is now implemented for offline messages, not sure though about mobile messaging if it was added to the log history or not. Could you test this and tell me if you find any bugs.
Thanks.

[sulfur]

As far as I know, this is now implemented for offline messages, not sure though about mobile messaging if it was added to the log history or not. Could you test this and tell me if you find any bugs.
Thanks.

ok, i did get an offline msg tonight.  amsn told me i received one and asked if i wanted to see it.  i said "ok", and up came an empty chat window.  totally empty.  odd.  i meant to get a screenshot of it, but kinda forgot because i got distracted with something else.  *Sigh*

if i get another, i'll definitely snap it.

further, i looked through the various log files, and couldn't find any messages that i hadn't outright seen in a window.  so... hard to say if it's buggy or not.

Edit:

Got a mobile msg this morning.  No times tagged on it at all still.  MSN in windows definitely tags them with the sent time.  Mobile messages don't log still either.  Still unsure on the offline ones.

Screenshot of a mobile window, still without times:

[sulfur]

Ok, so i got another offline message, and once again, a cool, totally empty chat window, as you can see below.  This was the result of saying "ok" to seeing the 1 offline message that i'd apparently received... which is now apparently lost for good, since it's definitely not in any of my log files either.

[sulfur]

further update:  as of revision 7626, outgoing mobile msgs log.  good work vivia!.

i will update this if/when i receive an incoming one.

[sulfur]

Ok, mobile msgs do log.  both incoming, and outgoing.  _HOWEVER_, they log oddly.  for example, here are some of the recent ones i've seen in my logfile:

[Conversation started on 15 Dec 2006 13:54:22]
[13:54:22] xxx@hotmail.com: Airport waiting sucks!
[15:07:09] xxx@hotmail.com: hope that you're in the air by now
[19:49:17] xxx@hotmail.com: hope all is good and that you're home safe
[20:03:05] xxx@hotmail.com: Im home

now, tell me, which ones are really which in that conversation?  it so happens in this case that they're fairly obvious, but what about in general?  they shouldn't be all logging with the same uid, especially since that's the log file that it's actually saved in!

secondly, and i'm not sure if this was noted above in one of my prior edits, but in the chat window, the messages look like:

mobilesays xxx@hotmail.com :
Airport waiting sucks!
[15:07:09] alex says:
hope that you're in the air by now
[19:49:17] alex says:
hope all is good and that you're home safe
mobilesays xxx@hotmail.com :
Im home


so, we get the times in the logfiles, but we can't get them in the chat window?  that kinda sucks really.

[vivia]

Hi, can you try now?

[sulfur]

Hi, can you try now?

not sure what happened, but incoming log, outgoing no longer log.  go figure.

still empty To: windows on offline msgs though as per the pic above.

[vivia]

OK, you try it. It's protocol.tcl line 8020. Sorry but I don't have any mobile contacts to test with....

Code:

       if {[::config::getKey keep_logs]} {
                ::log::PutLog $chatid [::abook::getPersonal login] $txt
        }

[sulfur]

OK, you try it. It's protocol.tcl line 8020. Sorry but I don't have any mobile contacts to test with....

Code:

       if {[::config::getKey keep_logs]} {
                ::log::PutLog $chatid [::abook::getPersonal login] $txt
        }

I've tried a number of things with this so far, and it seems that no matter what I do, it doesn't log, unless I go back to the revision before the one quoted above, and then it does log properly, just with the wrong names as reported above.  Very strange.