Thank you for your offer, I'm flattered but I really don't have the time or knowledge of TCL to be a true fulltime aMSN developer. If you don't mind I'd much rather help with occasional patches and ideas. However if I ever change my mind I'll be sure to let you know!

Now, I do need some help with all those features For one, how do I create a tooltip?
And do you have any idea why the picture isn't working as a drag source?

--edit:
p.s.
For the record, yes that's my account. Haven't used it in a while though :p

--edit2:
Hurray! I've got a test version working now
I can drag a file to my DP and it will be set, and I can drag my DP to somewhere else and my dummy proc gets executed

Since I was bored I've also started implementing DnD. It's kind of tough since I don't really know Tcl nor aMSN's code, but I think I've got part 1 implemented: you can drag a file onto your DP and it will change

Code:

Index: chatwindow.tcl
===================================================================
--- chatwindow.tcl      (revision 8944)
+++ chatwindow.tcl      (working copy)
@@ -2039,6 +2039,12 @@
                set buttons [CreateButtonBar $w $leftframe]
                set picture [CreatePictureFrame $w $paned]

+               # Drag and Drop DP
+               ::dnd bindsource [[GetInDisplayPictureFrame $w].image getinnerframe] Files "::ChatWindow::HandleInDPDrag $w"
+               ::dnd bindtarget [[GetInDisplayPictureFrame $w].image getinnerframe] Files <Drop> "::ChatWindow::HandleInDPDrop $w %D"
+#              ::dnd bindtarget [GetOutDisplayPicturesFrame $w] Files <Drag> "::ChatWindow::HandleOutDPDrag $w %D"
+#              ::dnd bindtarget [GetOutDisplayPicturesFrame $w] Files <Drop> "::ChatWindow::HandleOutDPDrop $w %D"
+
                pack $buttons -side top -expand false -fill x -anchor n \
                                -padx [::skin::getKey chat_buttons_padx] \
                                -pady [::skin::getKey chat_buttons_pady]
@@ -2254,7 +2260,7 @@
                ::dnd bindtarget [::ChatWindow::GetInputText $w] Files <Drop> "::ChatWindow::HandleFileDrop $w %D"
                #::dnd bindtarget [::ChatWindow::GetInputText $w] UniformResourceLocator <Drop> "%W insert end %D"
                ::dnd bindtarget [::ChatWindow::GetInputText $w] Text <Drop> {%W insert end %D}
-
+
                return $input
        }

@@ -2273,6 +2279,55 @@
        }

        ###############################################################
+       # getFilenameFromDND data                                     #
+       # ------------------------------------------------------------#
+       # Format a data string which has been aquired through TkDND   #
+       # into a valid tcl filename string.                           #
+       # If more then one filename is present in the input only the  #
+       # first will be returned                                      #
+       ###############################################################
+       proc getFilenameFromDND { data } {                           ;#TODO: Make HandleFileDrop use this too?
+               return [lindex [getFilenamesFromDND $data] 0]
+       }
+
+       ###############################################################
+       # getFilenamesFromDND data                                    #
+       # ------------------------------------------------------------#
+       # Format a data string which has been aquired through TkDND   #
+       # into an array of valid tcl filename strings.                #
+       ###############################################################
+       proc getFilenamesFromDND { data } {
+               set data [split $data "\n"] ;# Multiple filenames are separated by '\n' (TODO: True on Linux, needs testing on windows)
+               set retList [list]
+               foreach str $data {
+                       set str [string map {\r "" \n "" \x00 ""} $str]
+                       set str [urldecode $str]
+
+                       #If the str is enclosed in {}'s, strip off enclosing {}'s
+                       if { [string index $str 0] == "{" && [string index $str end] == "}" } {
+                               set str [string range $str 1 end-1]
+                       }
+
+                       #VFS (pseudo-)protocol: can't use these filenames(?)
+                       foreach type [list smb http https ftp sftp floppy cdrom dvd] {
+                               if {[string first $type $str] == 0} {
+                                       set str ""
+                               }
+                       }
+
+                       #If the str begins with "file://", strip this off
+                       if { [string range $str 0 6] == "file://" } {
+                               set str [string range $str 7 [string length $str]]
+                       }
+
+                       if { $str != "" } {
+                               lappend retList $str
+                       }
+               }
+               return $retList
+       }
+
+       ###############################################################
        # HandleFileDrop window data                                  #
        # ------------------------------------------------------------#
        # Proc called when a file is dropped to the input text widget #
@@ -2310,8 +2365,58 @@
                }
        }

+       ###############################################################
+       # HandleOutDPDrag window data                                 #
+       # ------------------------------------------------------------#
+       # Proc called when a drag action is initiated on the Out DP   #
+       ###############################################################
+       proc HandleOutDPDrag {window data} { ;#Drags may not need data
+               status_log "proc HandleOutDPDrag {$window $data}"
+       }

+       ###############################################################
+       # HandleOutDPDrop window data                                 #
+       # ------------------------------------------------------------#
+       # Proc called when a drag action is initiated on the Out DP   #
+       ###############################################################
+       proc HandleOutDPDrop {window data} { ;#Maybe when there is support for custom DP's for contacts
+               status_log "proc HandleOutDPDrop {$window $data}"
+       }
+
+       ###############################################################
+       # HandleOutDPDrag window data                                 #
+       # ------------------------------------------------------------#
+       # Proc called when a drag action is initiated on the Out DP   #
+       ###############################################################
+       proc HandleInDPDrag {window data} { ;#Drags may not need data
+               status_log "proc HandleInDPDrag {$window $data}"
+               return "/tmp/test.png"
+       }

+       ###############################################################
+       # HandleOutDPDrop window data                                 #
+       # ------------------------------------------------------------#
+       # Proc called when a drag action is initiated on the Out DP   #
+       ###############################################################
+       proc HandleInDPDrop {window data} {
+               status_log "proc HandleInDPDrop {$window $data}"
+               set file [getFilenameFromDND $data]
+               if { $file != "" } { ;#TODO: This is copy&pasted from gui::pictureChooseFile(), maybe it's possible to split is into a separate proc
+                       set convertsize "96x96"
+                       if { [catch {::picture::GetPictureSize $file} cursize] } {
+                       status_log "Error opening $file: $cursize\n"
+                       msg_box $cursize
+                       return
+                       }
+                       if { $cursize != "96x96" && ![::picture::IsAnimated $file] } {
+                               set convertsize [AskDPSize $cursize]
+                       }
+                       if { ![catch {convert_image_plus $file displaypic $convertsize} res]} {
+                               set_displaypic [filenoext [file tail $file]].png
+                       }
+               }
+       }
+
        proc CreateButtonBar { w bottom } {

                status_log "Creating button bar\n"

Next is finding a way to use the image as source as that doesn't seem to work atm, I think maybe the 'change display pic' popup is preventing tkDnD from seeing the mouse click?

--edit:
Regarding the better rescaling, I've heard from one of the dev's ('LePhilousophe') that it's 'a lot slower' then the regular scaling, so I've done some tests on my laptop (an Pentium-M, frequency set to 600mhz (lowest setting)):
Time to 'rescale dialog' - Time from 'rescale dialog to complete' - Total time: (scaling from 4800x3600 to default size 96x96)
New scaling:
0m44.434s - 0m51.258s - 0m95.692s
0m43.787s - 0m51.594s - 0m95.381s
0m43.560s - 0m50.518s - 0m94.078s
(0m43.927s - 0m51.123s - 0m95.050s average)
old Scaling:
0m44.417s - 0m46.844s - 0m91.261s
0m45.184s - 0m46.883s - 0m92.067s
0m44.733s - 0m46.098s - 0m90.831s
(0m44.778s - 0m46.608s - 0m91.386saverage)

Measurements were done with an stopwatch so they're not that accurate, but as you can see, the initial part (determining how large the picture is, NO SCALING IS HAPPENING YET) takes rougly 45seconds, rescaling using the 'old' scaling takes roughly double that time (46.6 seconds), where as the new scaling takes close to 51.1 seconds). Using the extreme values we get: 0m95.692s - 0m90.831s = 0m4.861s (5.352% slower) worst difference and 0m94.078s - 0m92.067s = 0m2.011s (2.184% slower) best case difference.
Conclusion:
In my personal opinion the quality gained well outweighs the 'slowdown' of a few seconds. People with slow computers shouldn't be opening this kind of 'huge' images in the first place, as can be clearly seen by the time it takes to just compute the size of the image. (Even people with fast computers shouldn't be opening these 'huge' pictures, with my frequency set to 1.7ghz (fastest) it still takes almost 35 seconds to open and resize this image using tcl. For reference, even on 600mhz kolourpaint takes only 4 seconds to resize the same image with equal quality. That's 0m91.386s/0m4.221s = 21.65 times faster)
As far as I can tell this patch can easily be added to aMSN without anyone noticing any (significant) slowdown.

Please note that these are just my findings, and might differ from your findings (although I can't image they will differ much). Please perform your own tests and post report your findings in this topic. I really would like to have nice scaling in amsn by default!
If you disagree with my findings let me know, BUT please do this same test yourself first (and don't forget to post the results here!) before telling me I'm wrong

Even though Tk does not use the GTK skin, it does use for example the default color for text. If you set a dark skin for GTK, chances are text is either white or light grey.
This is were things go wrong: you get light gr[ea]y text on an even lighter grey background, because TK doesn't use the default background color. I've had this problem too, but I just ignored it. The funny thing is that this does not happen everywhere (for example in the first screenshot the buttons are 'correct'). It might be as simple as specifically specifying the font colors to use on every text string that is drawn, but I'm not an amsn dev so I'm not sure.
In either case, I think it's only half an amsn bug, and half Tk. (Half amsn for not specifying a specific font color, half Tk for using the default foreground color but not the default background color).

Here's a patch to get a lot better scaling:

Code:

Index: utils/TkCximage/src/procs.cpp
===================================================================
--- utils/TkCximage/src/procs.cpp       (revision 8941)
+++ utils/TkCximage/src/procs.cpp       (working copy)
@@ -173,7 +173,7 @@
   item = TkCxImage_lstGetItem(Photo);
   if ( item != NULL ) {
     for(unsigned int i=0; i< item->NumFrames; i++) {
-      item->image->GetFrameNo(i)->Resample(width, height, 1);
+      item->image->GetFrameNo(i)->Resample2(width, height, CxImage::IM_BICUBIC2, CxImage::OM_REPEAT, NULL, false);
     }

     //We clear stored buffers and when we will display them they will be recreated
@@ -219,7 +219,7 @@
     if(alpha == 0 )
       image.AlphaDelete();

-    if(!image.Resample(width, height, 2)) {
+    if(!image.Resample2(width, height, CxImage::IM_BICUBIC2, CxImage::OM_REPEAT, NULL, false)) {
       Tcl_AppendResult(interp, image.GetLastError(), NULL);
       return TCL_ERROR;
     }

Here is a image showing the differences:

oktayD, yes, we would need to implement the ISF format, a proprietary format of microsoft which was reverse engineered a while ago by Ole Andre and me. Billiob is currently working on an implementation of that file format, and we hope to be able to have it available for 0.98.

Have you already implemented anything related to ISF? Have you documented your findings on the fileformat? (If you have, is any of it on SVN?)

I was playing with sendDraw yesterday and I discovered the same thing Zaskar did. Using highly unscientific methods I've concluded the maximum size for the gid is something like 40504-40511 pixels (Send a gif filled with random pixels, to prevent compression as much as possible, width and height don't seem limited, eg sending a 8x5063 image works just fine)

If you can send the image as ISF, are we no longer limited to 256 colors or filesize?

BTW is it possible to learn if the user could recieve Ink?

Do you mean like in Client Identification numbers?

I don't know how useful it would be, but some people might find it useful. I just hacked this together after a discussion with a friend why pidgin is 'better' than aMSN, just to prove him wrong.
This is just a rough version, and someone with TCL and commandline knowledge really should take a look at it, I'm just providing it as-is, no warranty etc. It's nothing more than a proof-of-concept.
plugininfo.xml:

Code:

<?xml version="1.0"?>
<plugin>
<name>runcmd</name>
<author>Da Fox</author>
<description>Similar to the Pidgin SlashExec plugin</description>
<amsn_version>0.97</amsn_version>
<plugin_version>0.1</plugin_version>
<plugin_file>runcmd.tcl</plugin_file>
<plugin_namespace>runcmd</plugin_namespace>
<init_procedure>InitPlugin</init_procedure>

<cvs_version>1.1</cvs_version>

<!-- <URL>
<main>http://amsn.sourceforge.net/autoupdater/plugins/changeit/changeit.tcl</main>
<plugininfo>http://amsn.sourceforge.net/autoupdater/plugins/changeit/plugininfo.xml</plugininfo>
<lang>http://amsn.sourceforge.net/autoupdater/plugins/changeit/lang/lang$langcode</lang>
<file>http://amsn.sourceforge.net/autoupdater/plugins/changeit/$file</file>
</URL> -->

</plugin>

and the code.
runcmd.tcl

Code:

namespace eval ::runcmd {
variable config
variable configlist
variable windowID

proc InitPlugin { dir } {
plugins_log "runcmd"  "initializing"
::plugins::RegisterPlugin runcmd
::plugins::RegisterEvent runcmd chat_msg_send msgSend

array set ::runcmd::config {
sendFailedCommands {0}
commandPrefix {!}
localCommandPrefix {!!}
verbatimPrefix {!!!}
commandInterpreter {}
commandTimeOut {} ;#Dummy / placeholder untill I find something which works better
}

if { [OnWin] } {
plugins_log "runcmd"  "Running on Windows"
set ::runcmd::config(commandInterpreter) {cmd /c}
# set ::runcmd::config(commandTimeOut) {This is not supported on windows, please empty this box. (if you know of a way to do this let me know)}
}
if { [OnLinux] } {
plugins_log "runcmd"  "Running on Linux"
set ::runcmd::config(commandInterpreter) {bash -c}
# set ::runcmd::config(commandTimeOut) {& sleep 1 ; kill -9 $!}
}
set ::runcmd::configlist [list \
[list label "This set the interpreter to use for commands"]\
[list label "(also helpfully works around my lack of TCL knowledge regarding 'exec')"]\
[list str "Command Interpreter:" commandInterpreter]\
[list label "The output from 'local commands' is only displayed in the conversation window, other people do not see it" ]\
[list label "The output from 'normal commands' is visable to everyone" ]\
[list label "The text from a 'verbatim command' is displayed as-is to everyone" ]\
[list str "Prefix for a normal command:"  commandPrefix ] \
[list str "Prefix for a local command:"  localCommandPrefix] \
[list str "Prefix for a verbatim command:"  verbatimPrefix ] \
[list label "" ]\
[list label "If this option is checked, commands which do not complete successfully will still be send" ]\
[list label "so that other people see for example 'cat: xxxxxxxx: No such file or directory'" ]\
[list bool "Send failed commands" sendFailedCommands] \
]
# [list label "" ]\
# [list label "This determines how long a subtask may run, by appended this command to the command string." ]\
# [list str "String to append:" commandTimeOut ] \
# ]
plugins_log "runcmd"  "initialization complete"
}

proc msgSend {event evpar} {
variable config
upvar 2 msg msg
upvar 2 chatid chatid
upvar 2 win_name win_name
variable runCmd
set runCmd 0
if { [string first $config(commandPrefix) $msg] == 0 } {
set runCmd 1
}
if { [string first $config(localCommandPrefix) $msg] == 0 } {
set runCmd 2
}
if { [string first $config(verbatimPrefix) $msg] == 0 } {
set runCmd 3
}
plugins_log "runcmd"  "runCmd = $runCmd"
switch $runCmd {
1 { ;# Normal command
variable cmdResult
variable cmdExitCode
variable cmd
variable cmdErrMsg
set cmdResult "FAIL"
set cmdExitCode -1
set cmd [concat [string range $msg [string length $config(commandPrefix)] end] $config(commandTimeOut) ]
plugins_log "runcmd"  "cmd = $cmd"
set cmdExitCode [catch {set cmdResult [exec {expand}[split $config(commandInterpreter) " "] $cmd]} cmdErrMsg]
plugins_log "runcmd"  "cmdExitCode = $cmdExitCode"
plugins_log "runcmd"  "cmdResult = $cmdResult"
plugins_log "runcmd"  "cmdErrMsg = $cmdErrMsg"
plugins_log "runcmd"  "msg = $msg"
if { $cmdExitCode == 0 } {
::amsn::MessageSend [::ChatWindow::For $chatid] 0 $cmdResult
} else {
if { $config(sendFailedCommands) == 1 } {
  ::amsn::MessageSend [::ChatWindow::For $chatid] 0 $cmdErrMsg
} else {
plugins_log "runcmd"  "Write error to window only"
::amsn::WinWrite [::ChatWindow::Name $win_name] "\n" grey
::amsn::WinWriteIcon [::ChatWindow::Name $win_name] greyline 3
::amsn::WinWrite [::ChatWindow::Name $win_name] "\n" red
::amsn::WinWriteIcon [::ChatWindow::Name $win_name] miniinfo
::amsn::WinWrite [::ChatWindow::Name $win_name] " Command failed:\n" red
::amsn::WinWrite [::ChatWindow::Name $win_name] "$cmdErrMsg\n" black
::amsn::WinWriteIcon [::ChatWindow::Name $win_name] greyline 3
}
}
set msg "" ;# Don't send any more messages
}
2 { ;# Local command
variable cmdResult
variable cmdExitCode
variable cmd
variable cmdErrMsg
set cmdResult "FAIL"
set cmdExitCode -1
set cmd [concat [string range $msg [string length $config(localCommandPrefix)] end] $config(commandTimeOut) ]
plugins_log "runcmd"  "cmd = $cmd"
set cmdExitCode [catch {set cmdResult [exec {expand}[split $config(commandInterpreter) " "] $cmd]} cmdErrMsg]
plugins_log "runcmd"  "cmdExitCode = $cmdExitCode"
plugins_log "runcmd"  "cmdResult = $cmdResult"
plugins_log "runcmd"  "cmdErrMsg = $cmdErrMsg"
plugins_log "runcmd"  "msg = $msg"
if { $cmdExitCode != 0 } {
set cmdResult $cmdErrMsg
}
plugins_log "runcmd"  "Write error to window only"
::amsn::WinWrite [::ChatWindow::Name $win_name] "\n" grey
::amsn::WinWriteIcon [::ChatWindow::Name $win_name] greyline 3
::amsn::WinWrite [::ChatWindow::Name $win_name] "\n" red
::amsn::WinWriteIcon [::ChatWindow::Name $win_name] miniinfo
if { $cmdExitCode == 0 } {
::amsn::WinWrite [::ChatWindow::Name $win_name] " Command output:\n" green
} else {
::amsn::WinWrite [::ChatWindow::Name $win_name] " Command failed:\n" red
}
::amsn::WinWrite [::ChatWindow::Name $win_name] "$cmdResult\n" black
::amsn::WinWriteIcon [::ChatWindow::Name $win_name] greyline 3

set msg "" ;# Don't send any more messages
}
3 { ;# Verbatim command
set msg [string replace $msg 0 [expr [string length $config(verbatimPrefix)] - 1] $config(commandPrefix)]
}
default { ;# Not really a command at all
}
}
}
}

As you can see there is /some/ support for killing a command if it takes too long to complete, but it's far from perfect (and thus disabled).
So you have to be careful not to do execute something like 'while true ; do false; done' or amsn will hang!

Hi, I'm having some problems with the svn version lately (last couple of weeks), and have submitted several bug reports each time. This is really quite annoying and I was just wondering if you are aware of this problem
This is the error description:

Code:

can't read "output": no such variable
    while executing
"return $output"
    (procedure "::base64::decode" line 43)
    invoked from within
"::base64::decode $context"
    (procedure "GetFilenameFromContext" line 4)
    invoked from within
"GetFilenameFromContext $context"
    (procedure "::MSNP2P::ReadData" line 202)
    invoked from within
"::MSNP2P::ReadData $p2pmessage $chatid"
    ("application/x-msnmsgrp2p" arm line 6)
    invoked from within
"switch $contentType {
text/plain {
::Event::fireEvent messageReceived $self $message
$message setBody [encoding convertfrom identity [strin..."
    (procedure "::SB::Snit_methodhandleMSG" line 100)
    invoked from within
"$self handleMSG $command $message"
    ("MSG" arm line 2)
    invoked from within
"switch [lindex $command 0] {
MSG {
$self handleMSG $command $message
}
BYE -
JOI -
IRO {
cmsn_update_users $self $comman..."
    (procedure "::SB::Snit_methodhandleCommand" line 24)
    invoked from within
"$options(-name) handleCommand $command $payload"
    (procedure "::Connection::Snit_methodreceivedData" line 37)
    invoked from within
"::MSN::SB3 receivedData"

I don't know what exactly this code does, but it appears it gets called with a string of 'MA', in which case it seems the variable output is never initialised?
Adding something like ' set output "" ' on line 280 of utils/base64/base64.tcl should fix that?

Additionally, it seems contact names are broken in revision 8923 on the main window, only the state and personal message are shown.


--------------------EDIT---------------------
This has now been fixed/worked around in r-8940.
The problem was someone using the 'kopete' msn client, which apparently sends some malformed base64 string. Better not use kopete :p

exactly what is siren_test?
Can't you convert the WAV files using for example mplayer?

In Account -> Preferences -> Others -> Sound Server -> Use a different program, change it so that it reads "aplay $sound"
That *should* fix it, but I'm not entirely sure as your error message has something about 'sox' in it?

da_fox: pixmapmenus problem and it is experimental and it was originally dropped because of this, it works 100% on some machines, on some others it doesn't, and there's just no way to fix it as it depends on everyone's version of .. something:s it even works on some winXP and doesn't on some other winXP.. how can we fix that? so enable pixmapmenus if you think it's stable for you, if it's not, then disable it.

Mja, I just thought I'd mention it
But it isn't going to be fixed then? Ever or just any-time-soon? (sorry if this has been asked a thousand times before)

Thanks! you could test the Development version of Emerald 2.0 (download from http://amsn.lnxteam.org)

I'll try it in the weekend if I have a little more time

I don't know, those sounds are from WLMSN (extracted from the app.), and i am pretend to compose my own sounds with Emerald 2.0, because obviously reason: are privative.

Are you sure? At least the sounds for MSN6 can be freely downloaded from Mess.Be (link)

[WOW!]

I just updated to the latest SVN, activated the Chameleon plugin and installed the Emerald theme, and all i can say is "WOW!"
This completely transforms the way aMSN looks, and I totally like it!
Great job everyone, and thank you GuS-Arg for the beautifull theme

There a two minor remarks though:
Firstly, (this is not related to chameleon related), the sounds in the emerald theme sound a bit ... strange, as if they were re-recorded instead of digitally extracted?
Secondly, after a short while the menu's will stop working. I can still right click and also the trayicon still works but all menu bars on the top of the window don't open anymore when clicked and also the mouse-over does not work anymore. Restarting aMSN only helps for a few minutes. I haven't tested yet but it may be the pixmapmenus

I think the problem with wmp is that there doesn't seem to be away to 'get' information from it about what files it is playing... If you can somehow 'ask' the program what file it is playing, (either  it has this functionality natively or via a plugin) than it's just a matter of adding a small script to amsn, but for wmp I don't think you can 'ask' it this...

I haven't actually tried the plugin myself, but I think that "Faking it!" does this, if I remember correctly you can say something and make it appear as if the person you're talking to said it.

You can always right-click the display picture and do size->normal or size->small. I don't if there is an option to do this automagically with overly large display picturers though, so a 'better' request would, IMHO, be to request an option to have aMSN display all display pictures in a specified size.

If you search VERY well in Preferences, Advance Tab: "Automatically resize display to default size", you will know that this options exist... to make default size for every DP.... (aMSN0.96RC1 and so on)

Cool! I didn't know that yet so thanks for the tip!

You can always right-click the display picture and do size->normal or size->small. I don't if there is an option to do this automagically with overly large display picturers though, so a 'better' request would, IMHO, be to request an option to have aMSN display all display pictures in a specified size.