smileys menu and handleLeaveEvent

[Zaskar]

I've noticed that the patch for the smileys menu to works correctly with beryl/compiz is working only if you move the mouse horizontally. There's a little mistake in the handleLeaveEvent proc (I think a typical copy/paste bug). It checks twice the x coord and never the y coord.

You should only replace the line 735 in smileys.tcl from:

Code:

if { $pointer_x == -1 || $pointer_y==-1 || $x < 0 || $x > $x_geo || $x < 0 || $x > $x_geo } {

to

Code:

if { $pointer_x == -1 || $pointer_y==-1 || $x < 0 || $x > $x_geo || $y < 0 || $y > $y_geo } {

and line 728 in the same file from

Code:

set window_y [winfo rootx $w]

to

Code:

set window_y [winfo rooty $w]

[Zaskar]

One more suggestion: you can add "moveinscreen $w 5" in line 457 so the smiley menu will always be completely inside the screen. Here's the diff for both changes:

Code:

456c456,457
<
---
>
>               moveinscreen $w 5
728c729
<               set window_y [winfo rootx $w]
---
>               set window_y [winfo rooty $w]
735c736
<               if { $pointer_x == -1 || $pointer_y==-1 || $x < 0 || $x > $x_geo || $x < 0 || $x > $x_geo } {
---
>               if { $pointer_x == -1 || $pointer_y==-1 || $x < 0 || $x > $x_geo || $y < 0 || $y > $y_geo } {

[kakaroto]

Hey, thanks zaskar for noticing! I committed it under your name, revision 8174