[SOLVED] corrupted png -> crash with *glibc double free..

[amsn_fan]

well I patched against 0.96stable and i get the same as you Chris.

I did a "./configure" and a "make" and it seems to be running fine. It updated some files.

If it crashes again I will let you know.

Incidentally deleting the "cache" directory doesnt help, it still writes faulty pngs which cause it to crash

[m3741]

Just to help out the unexperienced ones here goes an easy step-by-step guide:

WARNING!
All steps bellow should be done from within a terminal console such as aterm, eterm, konsole etc...
All steps should be done as normal user unless instructed otherwise.

1- Download amsn-0.96RC1.tar.bz2

Code:

wget http://easynews.dl.sourceforge.net/sourceforge/amsn/amsn-0.96RC1.tar.bz2

2- Extract the source code

Code:

tar -jxvpf amsn-0.96RC1.tar.bz2

3- Enter the folder created by the step above

Code:

cd amsn-0.96RC1

4- Run Configure in order to create the Makefile to be patched

Code:

./configure

5- Create the pacth file

Code:

vi patch.patch

Press the "Insert" button of your keyboard to enter the insert mode.
Copy the following text and paste it into the console with vi open:

Code:

diff -ur Makefile.in Makefile.in
--- Makefile.in 2006-04-28 00:10:17.000000000 +0200
+++ Makefile.in 2006-05-20 10:37:16.000000000 +0200
@@ -50,7 +50,7 @@
 LFS_FLAGS := -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64
 LIB_FLAGS := -I. -I$(capture_dir) -I$(capture_dir)/libng -I$(capture_dir)/structs
 LIB_FLAGS += -I$(webcamsn_dir)/src -I$(tkcximage_dir)/src -I$(tkcximage_dir)/src/CxImage
-LIB_FLAGS += -I$(tkcximage_dir)/src/zlib -I$(tkcximage_dir)/src/png -I$(tkcximage_dir)/src/jpeg
+LIB_FLAGS += -Ipng -Ijpeg
 LIBDIR := @LIBDIR@
 
 
@@ -100,7 +100,7 @@
 CXXFLAGS += -fPIC
 
 # libraries
-LDLIBS  := @LDLIBS@
+LDLIBS  := @LDLIBS@ -lpng -ljpeg
 LDFLAGS := @LDFLAGS@
 ifeq (@DEBUG@,no)
 LDFLAGS += -s
@@ -224,9 +224,6 @@
 include $(tkcximage_dir)/Rules.mk
 include $(tkcximage_dir)/src/Rules.mk
 include $(tkcximage_dir)/src/CxImage/Rules.mk
-include $(tkcximage_dir)/src/zlib/Rules.mk
-include $(tkcximage_dir)/src/png/Rules.mk
-include $(tkcximage_dir)/src/jpeg/Rules.mk
 include $(tkcximage_dir)/src/Rules.mk
 
 include $(webcamsn_dir)/Rules.mk
diff -ur utils/TkCximage/src/CxImage/ximajpg.cpp utils/TkCximage/src/CxImage/ximajpg.cpp
--- utils/TkCximage/src/CxImage/ximajpg.cpp 2006-04-13 15:22:27.000000000 +0200
+++ utils/TkCximage/src/CxImage/ximajpg.cpp 2006-05-18 23:03:20.000000000 +0200
@@ -9,7 +9,7 @@
 
 #if CXIMAGE_SUPPORT_JPG
 
-#include "../jpeg/jmorecfg.h"
+#include <jmorecfg.h>
 
 #include "ximaiter.h"
         
diff -ur utils/TkCximage/src/CxImage/ximajpg.h utils/TkCximage/src/CxImage/ximajpg.h
--- utils/TkCximage/src/CxImage/ximajpg.h 2006-04-13 15:22:27.000000000 +0200
+++ utils/TkCximage/src/CxImage/ximajpg.h 2006-05-19 10:12:38.000000000 +0200
@@ -29,8 +29,8 @@
 #define CXIMAGEJPG_SUPPORT_EXIF 1
 
 extern "C" {
- #include "../jpeg/jpeglib.h"
- #include "../jpeg/jerror.h"
+ #include <jpeglib.h>
+ #include <jerror.h>
 }
 
 class DLL_EXP CxImageJPG: public CxImage
diff -ur utils/TkCximage/src/CxImage/ximapng.h utils/TkCximage/src/CxImage/ximapng.h
--- utils/TkCximage/src/CxImage/ximapng.h 2006-04-13 15:22:27.000000000 +0200
+++ utils/TkCximage/src/CxImage/ximapng.h 2006-05-18 23:04:57.000000000 +0200
@@ -22,7 +22,7 @@
 #if CXIMAGE_SUPPORT_PNG
 
 extern "C" {
-#include "../png/png.h"
+#include <png.h>
 }
 
 long int inline btohl( long int dword ) {
diff -ur utils/TkCximage/src/Rules.mk utils/TkCximage/src/Rules.mk
--- utils/TkCximage/src/Rules.mk 2006-02-02 22:08:21.000000000 +0100
+++ utils/TkCximage/src/Rules.mk 2006-05-19 09:57:03.000000000 +0200
@@ -1,7 +1,5 @@
 OBJS-TkCximage := $(tkcximage_dir)/src/TkCximage.cpp.o $(tkcximage_dir)/src/PhotoFormat.cpp.o \
-  $(tkcximage_dir)/src/procs.cpp.o $(tkcximage_dir)/src/CxImage/libCxImage.a \
- $(tkcximage_dir)/src/jpeg/libjpeg.a $(tkcximage_dir)/src/png/libpng.a \
- $(tkcximage_dir)/src/zlib/libzlib.a
+  $(tkcximage_dir)/src/procs.cpp.o $(tkcximage_dir)/src/CxImage/libCxImage.a
 ifeq ($(STATIC),yes)
 OBJS-TkCximage += libstdc++.a
 endif

Save the file by pressing the "Esc" key of your keyboard and then type ':wq' (without the quotes, of course) and press enter.

6- Apply the patch you just created above:

Code:

patch -p0 < patch.patch

7 - Compile the source code

Code:

make

8- If everything went fine up to here, all you have to do is to install your recently compiled binaries:
Normal Linux users should do the following:

Code:

su -c "make install"

Ubuntu Linux users should do the following:

Code:

sudo make install

Now you are all done! Your newly compiled amsn should work like a charm now!

Troubleshooting:

If you did everything above and after you started amsn it crashed like it used to do before (error: libpng warning: Ignoring bad adaptive filter type) it is probably because there are still some broken cached display pictures in you cache folder.
In order to remove those all you have to do is remove the cached pictures by entering the following command:

Code:

rm ~/.amsn/YOUR_MSN_LOGIN_HERE_hotmail_com/displaypic/cache/*

Of course you have to substitute YOUR_MSN_LOGIN_HERE with your msn login without the @hotmail.com part.
For example, if your msn login is billy_gates@hotmail.com you should do the following:

Code:

rm ~/.amsn/billy_gates_hotmail_com/displaypic/cache/*

I hope this step-by-step guide is usefull to you.

Greetz from Brazil.

[snipe2004]

Hey thanks for this helpful and detailed post
Great work!

FdB, I think we should use a link to this post in our TroubleShooter

[FdB]

FdB, I think we should use a link to this post in our TroubleShooter

Lol you were lucky I read this whenever you fin something interesting you can PM me or even (a)MSN me, because I don't read all the topics in the forum I'm not inside the topic, but hey we can start the TS Project like in the 23rd this month cheers.

[ChrisRX]

I followed those instructions but it doesn't patch/compile properly

Code:

chris@localhost ~/Desktop/amsn-0.96RC1 $ patch -p0 < patch.patch
patching file Makefile.in
Hunk #1 FAILED at 50.
1 out of 3 hunks FAILED -- saving rejects to file Makefile.in.rej
patching file utils/TkCximage/src/CxImage/ximajpg.cpp
Hunk #1 succeeded at 9 with fuzz 1.
patching file utils/TkCximage/src/CxImage/ximajpg.h
patching file utils/TkCximage/src/CxImage/ximapng.h
patching file utils/TkCximage/src/Rules.mk
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file utils/TkCximage/src/Rules.mk.rej
chris@localhost ~/Desktop/amsn-0.96RC1 $ make
./configure
checking for prefix by checking for wish... /usr/bin/wish
checking for gcc... gcc
checking for C compiler default output file name... a.out
checking whether the C compiler works... yes
checking whether we are cross compiling... no
checking for suffix of executables...
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ANSI C... none needed
checking for g++... g++
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking tcl build dir... ./configure: line 2770: locate: command not found
using tcl library in /usr/lib
checking tk build dir... using tk library in /usr/lib
checking for main in -lstdc++... yes
checking how to run the C preprocessor... gcc -E
checking for X... libraries , headers
checking for gethostbyname... yes
checking for connect... yes
checking for remove... yes
checking for shmat... yes
checking for IceConnectionNumber in -lICE... yes
checking for ftello... yes
checking for fseeko... yes
checking for getpt... yes
checking for strcasestr... yes
checking for memmem... yes
checking for dlopen... no
checking for pthread_create in -lpthread... yes
checking if mmx should be used... yes
configure: creating ./config.status
config.status: creating Makefile
config.status: creating utils/linux/capture/config.h
config.status: utils/linux/capture/config.h is unchanged

compile time options summary
============================

    X11          : yes
    Tcl          : 8.4
    TK           : 8.4
    DEBUG        : no
    STATIC       : no

  CXX     utils/TkCximage/src/TkCximage.cpp.o
  CXX     utils/TkCximage/src/PhotoFormat.cpp.o
  CXX     utils/TkCximage/src/procs.cpp.o
  CXX     utils/TkCximage/src/CxImage/ximadsp.cpp.o
  CXX     utils/TkCximage/src/CxImage/ximaexif.cpp.o
  CXX     utils/TkCximage/src/CxImage/ximagif.cpp.o
  CXX     utils/TkCximage/src/CxImage/ximainfo.cpp.o
  CXX     utils/TkCximage/src/CxImage/ximajpg.cpp.o
  CXX     utils/TkCximage/src/CxImage/ximalyr.cpp.o
  CXX     utils/TkCximage/src/CxImage/ximapng.cpp.o
  CXX     utils/TkCximage/src/CxImage/ximatga.cpp.o
  CXX     utils/TkCximage/src/CxImage/ximatran.cpp.o
  CXX     utils/TkCximage/src/CxImage/ximabmp.cpp.o
  CXX     utils/TkCximage/src/CxImage/ximaenc.cpp.o
  CXX     utils/TkCximage/src/CxImage/ximage.cpp.o
  CXX     utils/TkCximage/src/CxImage/ximahist.cpp.o
  CXX     utils/TkCximage/src/CxImage/ximaint.cpp.o
  CXX     utils/TkCximage/src/CxImage/ximalpha.cpp.o
  CXX     utils/TkCximage/src/CxImage/ximapal.cpp.o
  CXX     utils/TkCximage/src/CxImage/ximasel.cpp.o
  CXX     utils/TkCximage/src/CxImage/ximath.cpp.o
  CXX     utils/TkCximage/src/CxImage/xmemfile.cpp.o
  AR      utils/TkCximage/src/CxImage/libCxImage.a
ar: creating utils/TkCximage/src/CxImage/libCxImage.a
make: *** No rule to make target `utils/TkCximage/src/jpeg/libjpeg.a', needed by `utils/TkCximage/src/TkCximage.cpp.so'.  Stop.

[vivia]

Get latest SVN version without applying the patch, this should work?

[MegaByte]

I don't know about him, but not for me. Please refer to http://amsn.sourceforge.net/forums/viewtopic.php?t=1573.

[ChrisRX]

Sorry for messaging again but it seems an svn checkout didn't fix the problem (I think it was on the 20th) .  My libpng is libpng-1.2.12-r1 (I think the r1 is gentoo specific updates)  There doesn't seem to be any updates to libpng in portage, I feel like I'm missing someything completely obvious here

[rosanero]

root[amsn-0.96RC1]# patch -p0 < patch.patch
patching file Makefile.in
patch: **** malformed patch at line 11:    -LIB_FLAGS   += -I$(tkcximage_dir)/sr c/zlib


the patch have an error at line 11...wich is this error?

i'm sorry for my englesh but i am italian lol

[vlsoft]

root[amsn-0.96RC1]# patch -p0 < patch.patch
patching file Makefile.in
patch: **** malformed patch at line 11:    -LIB_FLAGS   += -I$(tkcximage_dir)/sr c/zlib


the patch have an error at line 11...wich is this error?

i'm sorry for my englesh but i am italian lol

This means, you have some differences from the patch shown here and the one you copied. I'm almost sure, this is a line break, and the result is that on some line the first character is not from the following 4 characters + - # space
If you would like, then I can upload my patch file somewhere, but I have modified it for 0.96RC1 (a few spaces and tabs was the difference, so it should apply to any version, I think), and made my gentoo portage to automatically patch amsn with it.
But if so, you should PM me, because I'm not a frequent visitor here. That way I'll receive an e-mail, which I read daily and then I'll find some place to upload the .patch file.

[madd_matt]

Encebasderup's post is linking to a page distributing the "keycodec" badware as an .exe file.

You would be well advised to avoid that page

 Wonderful stuff it includes :
(a) "Internet Explorer Security Plugin 2006": Internet Explorer toolbar that protects your computer while you browse by setting high level of security for suspicious hosts.
(b) "Public Messenger ver 2.03": Popup advertising module that opens Internet Explorer ad windows when you are connected to internet.
(c) "Internet Security Add-On": your Internet Explorer homepage will be changed.
(d) Security software: antivirus/antispyware application.

And this is from their EULA on their website.

Don't you just love trolls?

Edit by admin: the message you refer to has been deleted, as we do our best to remove spam from our fora. I also removed several messages you wrote to protect visitors to follow these spam links.

[amsn_fan]

I got this again (recently).
How do you find out the offending PNG file?
I also note that when this happens, the "move over" function of displaying the users display pic etc when you move your mouse over their name in the contact list stops completely and does not work until you restart amsn.

This is using svn from 21.03 rev 8272!

[vivia]

Open the folder with one image editor, WHATEVER image editor as long as it depends on your system's libpng, and watch where it gives errors.

[adobo]

I know this is an old thread, but this problem seems not to be fixed.

I'm using amsn from svn (r8850) on Slackware 11.0 (libpng 1.2.16) and I'm suffering this crash for a long time. I use to empty my displaypic/cache directory when this happens, but that's a little annoying.

I have detected an image that makes amsn crash. If you're interested on it, please tell me and I will send it.

[Phil]

I already got several images that make hung aMSN but I can't reproduce the bug here....